Conversation
Enable shell command substitution via execute_commands=True on load_dotenv() and dotenv_values(), or --execute-commands on the CLI, so trusted .env files can populate variables from command output like gh auth token. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the gh auth token integration test that fails on unauthenticated runners, skip POSIX shell env expansion on Windows, and use python --version instead of printenv --version in CLI flag tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
Author
|
hey @theskumar — gentle bump. CI is green on this. if command sub isn't something you want in core, lmk and I can close or reshape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional
$(command)substitution in.envvalues, off by default.GITHUB_TOKEN=$(gh auth token)Turn it on with
execute_commands=Trueonload_dotenv()/dotenv_values(), or--execute-commandson the CLI (list,get,run).Runs after
${VAR}interpolation, so stuff likePREFIX=${BASE}-$(echo suffix)works. Failed commands warn and resolve to empty string.Test plan
uv run pytest(feature tests green locally)$(whoami),$(echo ...), mixed${VAR}+$(cmd),$(gh auth token)execute_commands=FalseNotes
)inside$(...)isn't supported (called out in the README).envfiles — commands run with the process's permissions@theskumar CI's been green for a bit. Happy to tweak naming/docs if anything feels off.