fast-get: move to object pool#10735
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom May 5, 2026
Merged
Conversation
lyakh
requested review from
abonislawski,
dbaluta,
iuliana-prodan and
kv2019i
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Zephyr fast-get implementation to allocate/track sof_fast_get_entry objects via the shared objpool API instead of manually reallocating a linear entry array.
Changes:
- Replace manual entry-array growth/reuse logic with an
objpool_head-backed pool. - Update
fast_get()/fast_put()entry lookup to useobjpool_iterate()callbacks. - Allocate new entries via
objpool_alloc()when no match is found.
lyakh
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Instead of allocating entries manually move fast-get to an object pool. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
wjablon1
reviewed
May 5, 2026
|
|
||
| return 0; | ||
| } | ||
| struct fast_get_find { |
Contributor
There was a problem hiding this comment.
LGTM,
I would just consider minor cosmetic changes:
fast_get_find -> fast_get_iter_arg
fast_get_find_entry -> fast_get_iter_fn
fast_put_find_entry -> fast_put_iter_fn
The proposed changes are more semantically accurate (as we perform a single iteration per function call).
wjablon1
approved these changes
May 5, 2026
lgirdwood
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of allocating entries manually move fast-get to an object pool.