audio: module: increase heap size#10740
Open
lyakh wants to merge 1 commit intothesofproject:mainfrom
Open
Conversation
The check-src-play.sh test fails on PTL nocodec with 20k module heap and passes with 24k. Increase it to 28k to add a bit of security until we switch to using module configuration. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the module adapter’s DP (userspace) module heap/vregion size to prevent check-src-play.sh failures on PTL nocodec configurations, adding headroom until the heap can be derived from module configuration.
Changes:
- Increased the DP module heap buffer size constant from 20 KiB to 28 KiB in
module_adapter_dp_heap_new()to avoid allocation failures under heavier SRC use.
Comments suppressed due to low confidence (1)
src/audio/module_adapter/module_adapter.c:74
- The comment says to "Make it 1k for the beginning", but the code currently reserves 4096 bytes for the lifetime partition. Please update the comment to match the actual size (or adjust the constant if 1k is intended) to avoid confusion when tuning vregion sizes.
/*
* A 1-to-1 replacement of the original heap implementation would be to
* have "lifetime size" equal to 0. But (1) this is invalid for
* vregion_create() and (2) we gradually move objects, that are simple
* to move to the lifetime buffer. Make it 1k for the beginning.
*/
return vregion_create(4096, buf_size - 4096);
kv2019i
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check-src-play.sh test fails on PTL nocodec with 20k module heap and passes with 24k. Increase it to 28k to add a bit of security until we switch to using module configuration.