Skip to content

audio: module: increase heap size#10740

Open
lyakh wants to merge 1 commit intothesofproject:mainfrom
lyakh:heap
Open

audio: module: increase heap size#10740
lyakh wants to merge 1 commit intothesofproject:mainfrom
lyakh:heap

Conversation

@lyakh
Copy link
Copy Markdown
Collaborator

@lyakh lyakh commented May 4, 2026

The check-src-play.sh test fails on PTL nocodec with 20k module heap and passes with 24k. Increase it to 28k to add a bit of security until we switch to using module configuration.

The check-src-play.sh test fails on PTL nocodec with 20k module heap
and passes with 24k. Increase it to 28k to add a bit of security
until we switch to using module configuration.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Copilot AI review requested due to automatic review settings May 4, 2026 10:24
@lyakh lyakh requested a review from ranj063 as a code owner May 4, 2026 10:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the module adapter’s DP (userspace) module heap/vregion size to prevent check-src-play.sh failures on PTL nocodec configurations, adding headroom until the heap can be derived from module configuration.

Changes:

  • Increased the DP module heap buffer size constant from 20 KiB to 28 KiB in module_adapter_dp_heap_new() to avoid allocation failures under heavier SRC use.
Comments suppressed due to low confidence (1)

src/audio/module_adapter/module_adapter.c:74

  • The comment says to "Make it 1k for the beginning", but the code currently reserves 4096 bytes for the lifetime partition. Please update the comment to match the actual size (or adjust the constant if 1k is intended) to avoid confusion when tuning vregion sizes.
	/*
	 * A 1-to-1 replacement of the original heap implementation would be to
	 * have "lifetime size" equal to 0. But (1) this is invalid for
	 * vregion_create() and (2) we gradually move objects, that are simple
	 * to move to the lifetime buffer. Make it 1k for the beginning.
	 */
	return vregion_create(4096, buf_size - 4096);

Comment thread src/audio/module_adapter/module_adapter.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants