Repository navigation
probe: add probe support for AMD ACP7x platform - #11363
Open
DINESHKUMARK1 wants to merge 1 commit into
Open
DINESHKUMARK1 wants to merge 1 commit into
DINESHKUMARK1 wants to merge 1 commit into
Conversation
Add the probe (data extraction) feature to the AMD ACP7x platform, so audio data can be tapped from pipeline buffers at runtime and streamed to the host over the compress device. Enable CONFIG_PROBE and the ACP host DMA probe path in the ACP7x board configuration, and keep the extractor DMA channel in acp_dma_dev_data::probe_ctx via struct acp_host_probe_data. The context is allocated when the extractor DMA is initialised and released when it is torn down, so the channel stays private to probe and does not reuse the DAI dai_index_ptr field. On ACP7x IPC3, look up probe points with ipc_get_buffer_by_id(). Probe point IDs name buffers, so the component-only lookup rejects valid IDs on this platform. Other IPC3 platforms keep ipc_get_comp_by_id(). Signed-off-by: DineshKumar Kalva <DineshKumar.Kalva@amd.com>
DINESHKUMARK1
requested review from
bhiregoudar,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
sunilkumardommati
as code owners
October 27, 2026 10:21
PR 11363: test resultsRun date: 2026-10-27 12:16 UTC Tested commit: 62945ad24490d399fcfdf1dff8633dd136f9a136
|
lgirdwood
reviewed
Oct 27, 2026
| dev = ipc_get_comp_by_id(ipc_get(), | ||
| IPC4_COMP_ID(buf_id->fields.module_id, | ||
| buf_id->fields.instance_id)); | ||
| #elif CONFIG_AMD |
Member
There was a problem hiding this comment.
If this is for IPC3 only then maybe it better to just say if ipc3 here ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the probe (data extraction) feature to the AMD ACP7x platform, so audio data can be tapped from pipeline buffers at runtime and streamed to the host over the compress device.
Enable CONFIG_PROBE and the ACP host DMA probe path in the ACP7x board configuration, and keep the extractor DMA channel in acp_dma_dev_data::probe_ctx via struct acp_host_probe_data. The context is allocated when the extractor DMA is initialised and released when it is torn down, so the channel stays private to probe and does not reuse the DAI dai_index_ptr field.
On ACP7x IPC3, look up probe points with ipc_get_buffer_by_id(). Probe point IDs name buffers, so the component-only lookup rejects valid IDs on this platform. Other IPC3 platforms keep ipc_get_comp_by_id().
Companion Zephyr driver change (host DMA probe support): https://github.com/zephyrproject-rtos/zephyr (drivers/dma/dma_amd_acp_host.c, CONFIG_AMD_ACP_HOST_DMA_PROBE) is required alongside this for the feature to function; see that PR for the kernel-side register-matching note (probe_reg_offset must point at ACP_FUTURE_REG_ACLK_2 on the Linux side).