fix(ci): clear the red govulncheck gate — toolchain go1.26.6, drop stale GO-2026-5668 exception (agent-os-twiq) - #209
Merged
Merged
Conversation
The required `Go vulnerabilities (govulncheck)` check was red on main, blocking every PR. Five Go stdlib advisories (GO-2026-6218 net/url, GO-2026-6090 crypto/tls, GO-2026-6089 net/http, GO-2026-5972 encoding/asn1, GO-2026-5026 net/http) all report "Found in ...@go1.26.5 / Fixed in ...@go1.26.6", so bump the toolchain directive to go1.26.6. The `go 1.25.0` language directive is unchanged. Also drop GO-2026-5668 from the accepted-exceptions allow-list. It no longer appears at symbol tier — govulncheck traces no call to it, and CI had started printing it as a stale exception on every run. It still shows at module tier alongside GO-2026-5746 and GO-2026-5617, so its reachability note moves into the "deliberately not in the list" block rather than being deleted, and the surrounding counts and back-references are corrected to match. After: govulncheck reports only GO-2026-4887 and GO-2026-4883, both docker/docker with "Fixed in: N/A" and both already allow-listed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required check
Go vulnerabilities (govulncheck)is red onmainitself, blocking every PR (including all five open Dependabot PRs).What
backend/go.mod:toolchain go1.26.5→toolchain go1.26.6. Clears the five stdlib advisories reported since go1.26.6 shipped: GO-2026-6218 (net/url), GO-2026-6090 (crypto/tls), GO-2026-6089 (net/http), GO-2026-5972 (encoding/asn1), GO-2026-5026 (net/http) — each "Fixed in go1.26.6"..github/workflows/security.yml: removeGO-2026-5668from the accepted-exceptions list — CI has been printing::notice::Stale govulncheck exceptions (no longer reported): GO-2026-5668. Its reachability paragraph moves to the "deliberately not in the list" block (it is still a real module-tier finding), with the surrounding counts and cross-references corrected.Verification (local, re-executed by the orchestrator)
Before, on main@2546170:
govulncheck ./...→ "affected by 7 vulnerabilities". After: only GO-2026-4887 and GO-2026-4883 (docker/docker,Fixed in: N/A, both accepted with written reachability evidence). Zero stdlib advisories.go build ./...exit 0 under go1.26.6. CI's own jq gate logic replayed against a fresh-format jsonreport: unexpected-set empty, stale-set empty.Note: PR #207 (golang image 1.26.6-trixie) is complementary — it bumps the Docker build image, this bumps the toolchain govulncheck builds with. Both belong landed.
Partly resolves the re-check tracked in agent-os-96h (three of its five advisories no longer reported; recorded on the bead).
🤖 Generated with Claude Code