Repository navigation
Test: Always run the TypedPython leak test now that #98 is fixed - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #98 (merged via #118) and #45.
TypedPythonKotlinCallTest.tenThousandCompiledCallsLeakNoReferenceAndNoKotlinHandleno longer skips on-Dtypedpython.leakTest. That property never reached the test JVM from the Gradle CLI anyway.TypedPythonBridge.kt: corrected the comment that blamedclose()inside an upcall for a double release. The crash came from a test wrapping fake addresses as owned objects.Verification (local, macOS arm64, JDK 21):
:ksp-fixtures:app:desktopTest --rerun -PtypedpythonPython=<venv with pyrefly 1.3.2>, test-results deleted first: 79 tests, 0 failures, 0 errors, 0 skipped. The leak test ran (1.29 s) and passed.Note: without a host Python that has pyrefly (
-PtypedpythonPythonorpython-multiplatform-ksp/.venv),buildTypedPythonBridgeis skipped and all four TypedPython tests report skipped. A plain run gave 79/0/0 with 4 skipped for that reason, not because of #98.