Repository navigation
Refactor: Sample's Python sources live under sample/src/commonMain/python - #171
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106
Moved sample/python/src/main/example_py to sample/src/commonMain/python/example_py (app-template layout, app/src//python) and sample/python/pyproject.toml to sample/pyproject.toml; sample/python is gone. The only consumer is the iOS app's Xcode build phase (PYTHON_PAYLOAD_DIR), updated with docs/platforms/ios-app-bundle.md; the directory's contents still become /python/, so example_py lands at the same place. Desktop and Android do not stage this payload.
Not verified on a simulator in this PR: #107 moves the Xcode project next and touches the same build phase, so the iOS DEMO 8 check runs once after #107.