Repository navigation
Refactor: The iOS app is sample/src/iosMain/app.xcodeproj; root iosApp removed - #173
Merged
Merged
Conversation
…o levels up from the project (#107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
The sample's template-layout Xcode project (app-template app/src/iosMain) is now the single iOS project; root iosApp/ is removed. Ported from iosApp: the install-python build phase (stdlib, extension modules wrapped as frameworks, the app's payload from sample/src/commonMain/python), Python.xcframework link and embed, bundle id org.thisisthepy.python.multiplatform.demo, product PythonDemo.app, the SwiftUI entry (ContentView/iOSApp). Removed: the unpopulated build/pythonStaging folder reference, the missing EmbeddedPython group, the template's launch storyboard (wrong Info.plist key; SwiftUI app uses UILaunchScreen as iosApp did). Docs: ios-app-bundle.md procedure and ROADMAP updated.
Verified on the iPhone 16 simulator from the new location (procedure in docs/platforms/ios-app-bundle.md): xcodebuild EXIT=0, 'Wrapped 67 extension module(s)', payload installed; launch prints DEMO 1 to DEMO 8, DEMO 8 bundle is a tuple with the payload greeting and _json loaded from its .fwork. Desktop/Android are not affected (no Gradle source changes besides one comment).