Repository navigation
Fix: Stub paths are case-unique; Python-keyword Kotlin names left out - #49
Merged
Merged
Conversation
…words are left out A class module whose path collides case-insensitively with a sibling (Compose's graphics.Shadow vs the graphics.shadow package) is emitted as a class inside its parent's __init__.pyi; non-colliding class modules keep their own path. macOS and Windows can now extract and type-check the stub set. That exposed a second defect: Shadow.None was written as 'None: Shadow', a syntax error that made mypy skip the whole module. A Kotlin name that is a Python keyword cannot be an attribute or def in Python at all; the stub now leaves it out with a comment naming getattr(). A stubs-macos CI job checks both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Coordinator verification: plugin tests 171/0; Compose 1.11.1 stubs regenerated: 0 casefold collisions; tools/stubs/check-stubs.sh on macOS: Success, no import ignore; artifact fixtures 35/0.