Repository navigation
Gradle plugin: feed stubs to typedpythonStubs - #50
Merged
Merged
Conversation
…figuration When a configuration named typedpythonStubs exists (toolchain's plugin creates it), every stubs task's output directory is added to it with the task dependency attached, in either plugin application order. No compile-time dependency on toolchain; nothing is created when the configuration is absent. Red: 3 of 4 failed. Green: 4/4, full plugin suite 151/0. Mutation (wiring call removed): 3 fail again. Closes #27
…tubs-wire # Conflicts: # docs/SPEC.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Feature added
When a configuration named
typedpythonStubsexists (toolchain's plugin creates it, toolchain#23 and PR toolchain#34), eachPythonStubsTaskoutput directory is added to it, and the task dependency travels with the files. This works whichever plugin is applied first. There is no compile-time dependency on toolchain, and if the configuration never appears, nothing is created.Test added
TypedPythonStubsWiringTest, 4 tests (ProjectBuilder, two source sets):generatePythonStubs*;Results:
:python-multiplatform-gradle-plugin:testgave 151 tests, 0 failures, 0 errors, 0 skipped. The coordinating session re-ran the class and got 4 of 4.Documentation corrected
SPEC B-8 is marked implemented.
Not run
ksp-fixturesand the library module were not run; the machine is overloaded. The toolchain side that consumes the configuration is not exercised here.