Repository navigation
Fix: Decline extension functions on receivers with off-classpath supertypes; pin Icons.Default.Add in the stubs - #80
Merged
Merged
Conversation
…he compile classpath (#66)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
Closes #68
Defect fixed: extension functions whose receiver has a supertype missing from the compile classpath are declined with a reason (same rule as properties, #38). #68 was already fixed by #67; consumer.py now asserts
assert_type(Icons.Default.Add, ImageVector)(fails on pre-#67 stubs with 'Expression is of type Any', passes on #67 stubs).Verification (coordinator, separate modules): plugin 225/0, desktopTest 561/0, ksp artifact 35/0, app 70/0, compose 111/0, androidNative OK. Red without the fix: PropertyBindingTest.aReceiverWithASupertypeOffTheClasspathHasItsExtensionFunctionsDeclined.