Repository navigation
Feat: TextFieldState from Python; bind value-class constructors and CharSequence results - #84
Merged
Merged
Conversation
…__init__ stubs (SPEC B-1, B-7, #73)
…ructor __init__ keys; a class name is its constructor (#73) - A value class that crosses as its raw number keeps `def X(...) -> float` (its __init__ would lie). - A single __init__ carries 'Kotlin constructor: <key>' so the stub invariant sees it. - ColorScheme now resolves to its constructor like Typography/Shapes; test rewritten to say so. - TextFieldStateRenderTest uses TextRange__Int: the bare name is shadowed by the TextRange companion module (pre-existing; filed separately).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73
Root causes: foundation.text.input not walked; constructors with value-class params are public synthetic DefaultConstructorMarker bridges and were dropped with HIDDEN ones; kotlin.CharSequence had no boundary type.
Feature added: TextFieldState(...)/rememberTextFieldState, .text as str, setTextAndPlaceCursorAtEnd/clearText; CharSequence returns cross as str (parameters still declined); a class's own constructor is its stub init (marker 'Kotlin constructor:'), primitive value classes keep def X -> float; a Kotlin class name in Python is its constructor (ColorScheme like Typography/Shapes).
Follow-up: #78 (companion module shadows TextRange(…) factory).
Verification (coordinator, after merging develop): plugin 243/0, desktopTest 580/0, ksp artifact 35/0, app 70/0, compose 114/0, androidNative OK.