Repository navigation
Fix: Real libpython in the desktop jar, staged prefix and packaged home; extract into a cache - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Defect fixed (SPEC L-9a)
libpython3.14.sois a symlink; Gradle's tarTree extracted it as a 0-byte file, so the desktop jar, the plugin's staged PYTHONHOME prefix and Desktop: ship the stdlib with a packaged app (jar/jpackage), not only via PYTHONHOME for Gradle tasks #60's packagedpython-multiplatform-homeall carried an empty library (toolchain#22 desktop-e2e: 'file too short'). The plugin now extracts the archive itself and materialises symlinks/hard links as copies of their targets (staging stamp bumped → old prefixes re-extract); the jar packs the real file under the loader's name; the packaged-home copy fails the build on any 0-byte libpython*.Tests added: DesktopJarLibrariesTest, ExtractLibraryCacheTest, StagedPrefixLinksTest.
Verification (coordinator, after merging develop, each module separately): plugin 254/0, desktopTest 590/0, ksp artifact 35/0, app 70/0, compose 115/0, androidNative OK. Jar listing: lib/linux-x86_64/libpython3.14.so 251,884,016 bytes (was 0), no .so.1.0.
Not done: linux library ships unstripped from a macOS build host (no ELF strip) — follow-up issue.