Repository navigation
Fix: Serve a Kotlin object as a namespace when the binder lists it itself - #42
Merged
Merged
Conversation
…self python-multiplatform #35 (PR #51, develop d6d39787) lists a Kotlin object's sub-package in its parent module's dir() and exposes it as an attribute. The re-export's name table therefore found Arrangement directly and handed back the binder's raw module, whose function is spacedBy: Arrangement.spaced_by failed and dir() showed Kotlin names. A Kotlin module reached through the table is now wrapped as a KotlinObject, the same as the import fallback does for an older binder. defect fixed: unwrapped Kotlin objects against python-multiplatform d6d39787. Red: against d6d39787, 3 tests failed (ObjectNamespaces x2, the object-function stub test). After: 144 passed against d6d39787 (exported read-only) and the sibling checkout. No test added: the existing ones caught it. Refs #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
Since python-multiplatform #35, the binder exposes
Arrangementas an attribute of its parent. Our name table then returned the raw Kotlin module, soArrangement.spaced_bybroke. A Kotlin module reached through the table is now wrapped as aKotlinObject.Defect fixed. Red: 3 tests failed against
d6d39787. After: 144 passed againstd6d39787and the sibling checkout. The existing tests caught it, so no new test.