Skip to content

ORB-164 PR4: remove CI reviewer and align review contracts - #446

Merged
thomasluizon merged 1 commit into
mainfrom
thomasluizon/orb-164-pr4-debloat
Jul 31, 2026
Merged

ORB-164 PR4: remove CI reviewer and align review contracts#446
thomasluizon merged 1 commit into
mainfrom
thomasluizon/orb-164-pr4-debloat

Conversation

@thomasluizon

@thomasluizon thomasluizon commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Harness-Lockstep-Peer: 669

Closes ORB-164. Paired with thomasluizon/orbit-ui-mobile#669.

What changed

This is the orbit-api lockstep half of ORB-163 PR4.

  • Deletes claude-review.yml.
  • Aligns the contract-aligner, security-reviewer, PR review skill, rubric, second-opinion skill, and byte-exact second-opinion helper with the UI peer.
  • Makes Critical and High findings eligible for a second opinion in unattended and interactive reviews.
  • Removes model selection from the review skill and records that review is orchestrator-side, not a CI status.
  • Mirrors the approach-first and durable-strike worker rules in AGENTS.md.
  • Corrects the Dependabot comment for the zero-required-approval protection state.

No new external response field is read by this repository diff. GitHub response evidence for the merge-sweep behavior lives in the UI peer body.

Verification

  • Skill and Agent Frontmatter: exit 0, 8 files parsed.
  • Dash baseline: exit 0.
  • Diff check: exit 0.
  • Added U+2014 count: 0.
  • Cross-repository lockstep: exit 0, 6 pairs.

Rollback

Revert this pull request and the UI peer together. Reverting only one side makes the required Harness Lockstep context fail. A full ORB-163 rollback also needs the recorded branch-protection payloads restored manually.

@thomasluizon

Copy link
Copy Markdown
Owner Author

Approach before review: land the API-side workflow deletion and all affected review-contract twins as one self-consistent commit in .github/workflows/, .claude/agents/, .claude/skills/, AGENTS.md, and CLAUDE.md. The UI peer owns the lockstep fingerprints and executable harness cases. I rejected a partial twin-only commit because its prose would describe a zero-approval local-review path while the CI reviewer still existed, and rejected keeping the second-opinion helper Critical-only because the aligned skills now route both Critical and High findings through it.

@sonarqubecloud

Copy link
Copy Markdown

@thomasluizon

Copy link
Copy Markdown
Owner Author

Automated activity IC_kwDORKgXhc8AAAABMp8nWg acknowledged. No code change required: SonarQube Cloud reports the Quality Gate passed with zero new issues and zero security hotspots. Evidence: 8c5f3c6

@thomasluizon
thomasluizon merged commit d37468d into main Jul 31, 2026
24 of 25 checks passed
@thomasluizon
thomasluizon deleted the thomasluizon/orb-164-pr4-debloat branch July 31, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant