fix(api): secure settings api against unauthorised access - #105
Open
anaghwadhwa123 wants to merge 1 commit into
Open
fix(api): secure settings api against unauthorised access#105anaghwadhwa123 wants to merge 1 commit into
anaghwadhwa123 wants to merge 1 commit into
Conversation
anaghwadhwa123
force-pushed
the
fix/settings-api-auth
branch
from
July 29, 2026 07:09
bfe12bf to
464e44f
Compare
anaghwadhwa123
force-pushed
the
fix/settings-api-auth
branch
from
July 29, 2026 07:27
464e44f to
ad8328f
Compare
officialid130-13e13
approved these changes
Aug 3, 2026
officialid130-13e13
left a comment
There was a problem hiding this comment.
Hi @anaghwadhwa123,
- Completed local verification of the changes in the dev container.
- The /api/settings endpoint now enforces authentication as expected.
- Unauthenticated access consistently returns 419 CUSTOM with the correct error payload.
- This matches the intended behaviour described in the PR.
No issues identified.
Approved.
|
@anaghwadhwa123 , I also attempted to generate a valid auth token via Swagger, but the token didn’t work, so I wasn’t able to fully validate the authenticated request flow. Happy to re‑test once a working token is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves Finding 6.6 (Unauthenticated Access to System Settings) from the previous trimester's vulnerability remediation report. Previously, the
/settingsand/settings/privacyendpoints insidesettings_api.rbwere publicly accessible without authentication. This fix adds theAuthenticationHelpersmodule and enforces abefore { authenticated? }block to ensure only authenticated users can access system settings.Fixes # Finding 6.6 from the Vulnerability Remediation Report

Type of change
How Has This Been Tested?
Verified that accessing the settings endpoints requires valid user authentication, matching existing secure APIs like
users_api.rbandprojects_api.rb.Tested locally against the running development server using
curl:Output:
This confirms unauthenticated requests are correctly rejected, consistent with the authentication behavior used across all other protected endpoints in the API.

Checklist: