Fix/msys2 test issue (original PR #132) - #169
Open
rory-cd wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a copy of #132, created by former contributor @ConnorClancyDeakin. The fix resolves an important bug when running tests in MSYS2.
The original PR had 2 approvals, however the user has deleted their account, which closed the PR (hence the need to re-raise).
Original Description (#132)
The sktest.exe has been unable to work on the MSYS2/MINGW64 it was getting stuck in one test and wasnt giving any feedback the terminal would freeze up (if you want to simulate the error you should be able to just run the sktest in you msys2 mingW64) The change that has been provided here changes the way the test is built to be a console exectuable which has made it work on my machine.
Fixes sktest.exe not working in MSYS2/MINGW64
Type of change
How Has This Been Tested?
First you must be using MYSYS2/WINGW64 although it could be beneficial to check with others as well to make sure it doesnt stop anything else from working
This change can be tested by simply building and testing the program using the sktest.exe file when you do this it should let you choose any test and run them as well as exit the program. The tests should complete and bring you back to the main terminal to choose another test. Essentially you should get a terminal menu when you run the sktest.exe that you can use.
Testing Checklist
Checklist
Extra note
This change changes the way the sktest is built as far as I've been able to find there has been no uninteded consequences of this but I havent done a change like this before, it should only effect the sktest.exe when msys is being used but if you know more than me and think this should be different please put that in your peer review as I do not want to break things on accident. essentially please dont be afraid to be harsh.