Skip to content

Fix NoMethodError by using Octokit's add_label to create missing labels #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilvcarvalho merged 1 commit into from
Aug 3, 2026
Merged

Fix NoMethodError by using Octokit's add_label to create missing labels #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@

### Fixed

- Use Octokit's `add_label` instead of the nonexistent `create_label` when
creating missing labels, which raised `NoMethodError` with Octokit v10.

### Security
2 changes: 1 addition & 1 deletion lib/github_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def ensure_labels(labels)
existing = list_label_names
labels.each do |label|
next if existing.include?(label)
@client.create_label(@repo, label, "0075ca")
@client.add_label(@repo, label, "0075ca")
end
end

Expand Down
6 changes: 3 additions & 3 deletions test/github_client_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,19 @@ def test_ensure_labels_is_a_no_op_when_labels_is_empty

def test_ensure_labels_creates_missing_labels
@octokit.expect(:labels, [label_stub("dependencies")], [REPO])
@octokit.expect(:create_label, nil, [REPO, "javascript", "0075ca"])
@octokit.expect(:add_label, nil, [REPO, "javascript", "0075ca"])
@client.ensure_labels(%w[dependencies javascript])
end

def test_ensure_labels_skips_labels_that_already_exist
@octokit.expect(:labels, [label_stub("dependencies"), label_stub("javascript")], [REPO])
# No create_label calls expected.
# No add_label calls expected.
@client.ensure_labels(%w[dependencies javascript])
end

def test_ensure_labels_tolerates_labels_list_failure
@octokit.expect(:labels, nil) { |_repo| raise Octokit::Error }
@octokit.expect(:create_label, nil, [REPO, "dependencies", "0075ca"])
@octokit.expect(:add_label, nil, [REPO, "dependencies", "0075ca"])
@client.ensure_labels(%w[dependencies])
end

Expand Down