SCAL-303771 Added isSpotterErrorBannersEnabled for new spotter banner#522
Open
animesh935 wants to merge 2 commits intomainfrom
Open
SCAL-303771 Added isSpotterErrorBannersEnabled for new spotter banner#522animesh935 wants to merge 2 commits intomainfrom
animesh935 wants to merge 2 commits intomainfrom
Conversation
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the isSpotterErrorBannersEnabled configuration option across AppEmbed, SpotterEmbed, and LiveboardEmbed, allowing users to opt into the new Spotter error banner UI. The changes include updates to the SpotterChatViewConfig interface, the Param enum, and the addition of relevant unit tests. Feedback was provided regarding a style guide violation in the JSDoc documentation for the new property, specifically concerning the canonical tag ordering and the formatting of the ThoughtSpot version string.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.