[pull] main from django:main - #521
Merged
Merged
Conversation
Without also mocking the global settings, there was pollution of the
test database name, since create_test_db() writes like so:
self.connection.settings_dict["NAME"] = test_database_name
This caused other tests that explicitly reopen database connections to
fail under parallel test execution (in forkserver mode) because at the
moment of reopening, the db name was `memorydb_default` rather than the
suffixed version `memorydb_default_3`:
backends.sqlite.tests.ThreadSharing.test_database_sharing_in_threads
servers.tests.LiveServerInMemoryDatabaseLockTest.test_in_memory_database_lock
This aims for consistency in the django.db.models namespace. Thanks Natalia Bidart and Simon Charette for the idea.
…ndex. Thanks Jacob for the triage and James for the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )