Migrate zosbase -> zos_base module (v1.1.0)#33
Closed
ashraffouda wants to merge 2 commits into
Closed
Conversation
The zosbase module was renamed to github.com/threefoldtech/zos_base. Update the go.mod require (v1.0.3 -> zos_base v1.1.0), go.sum, and the import statements. The nested tools/zos-update-worker module does not use zosbase and is untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ashraffouda
requested review from
Eslam-Nawara,
Omarabdul3ziz,
rawdaGastan and
xmonader
as code owners
The 'Set up Go' step (setup-go@v1) fails on the current GitHub host runner (Node 24), blocking the build before it compiles. Bump to v5 so CI can validate the zos_base migration. Container builders are untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing/deferring: zos_v4 is pinned to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Go dependency from
github.com/threefoldtech/zosbasetogithub.com/threefoldtech/zos_base@v1.1.0(threefoldtech/zos_base#119), removing the Go-import dependency on GitHub's rename redirect.go.mod:zosbase v1.0.3->zos_base v1.1.0go.sumupdatedtools/zos-update-workermodule does not use zosbase and is untouchedNote: version jump v1.0.3 -> v1.1.0; CI validates. Part of the P1 module-path migration — #2693.