Skip to content

fix(net/local): bound release-boundary settle drain in TestReleaseBroadcastChannel #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotr-roslaniec merged 1 commit into from
Sep 3, 2026
Merged

fix(net/local): bound release-boundary settle drain in TestReleaseBroadcastChannel #4284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/net/local/broadcast_channel_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ func TestReleaseBroadcastChannel(t *testing.T) {
// sent, not a sign the ticker "kept firing" - so absorb it in a short
// settle window before asserting the real invariant this test cares
// about: no further deliveries once release has taken effect.
drain(ch1Deliveries, RetransmissionTick)
if got := drain(ch1Deliveries, RetransmissionTick); got > 1 {
t.Errorf("expected at most one straggler tick after release, got %d", got)
}

if got := drain(ch1Deliveries, RetransmissionTick*3); got != 0 {
t.Errorf("expected no deliveries after release, got %d", got)
Expand Down
Loading