Clean up and re-organize Thunder UI widgets#2113
Merged
Merged
Conversation
hjiangsu
force-pushed
the
refactor/thunder-ui-widgets
branch
from
34df3aa to
2a2e54a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR consolidates Thunder's shared UI widgets into the UI package and cleans up the existing widgets. This includes migrating existing widgets/logic to use the new shared widgets with the goal of making everything a bit more consistent. With this, a bunch of tests have been added as well, and I've also updated some logic to allow Thunder to connect to HTTP instances for testing (development flavour only)
I did some broad testing across the app and everything seems to be working as expected so far!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?