fix: request assistant reply for structured output#141
Open
huilang021x wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex please review this PR when you have a chance. Context: this fixes OpenCode structured output usage by requesting an assistant reply instead of |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noReply: falsefor transient OpenCode structured-output prompts and update the opencode-provider regression test.noReply: trueas context-only, returning before the assistant loop that populatesinfo.structured.Scope
generateStructuredOutput()calls through OpenCode v2session.prompt; related unit test expectation.Deployment Targets
opencodeProvider+opencodeModelfor auto-capture/profile structured output.noReply: truerequest behavior.Acceptance Plan
info.structured; transient sessions are still deleted.Validation
bun test tests/opencode-provider.test.tsbun run typecheckbun run format:checkbun run build && bun test156 pass, 0 fail.