fix: custom modules image not showing on ios prod#139
Merged
Conversation
DanielOS7-TM
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header image passed via
customModules.headerView.imagetoIgniteProviderdoesn't render on iOS release builds. It works in debug and on Android.The SDK's
RCTNativeConfig.getImage:strips thefile://prefix with a string slice and passes the result toUIImage imageWithContentsOfFile:— which takes a filesystem path, not a URL, and does not percent-decode. On release, expo-updates serves the asset fromLibrary/Application Support/.expo-internal/..., so the URI contains%20for the space in "Application Support". The encoded space survives the strip and the file lookup fails.This parses the value as an
NSURLand usedataWithContentsOfURL:for any URL with a scheme, letting Foundation handle decoding. Bare filesystem paths still fall through toimageWithContentsOfFile:.