Add SeccompProfile to Waypoint proxies#5033
Open
alexh-tigera wants to merge 1 commit into
Open
Conversation
Allow Waypoint proxies to run in PSA restricted mode.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Istio rendering logic in the operator to ensure Waypoint (gateway-style) proxies are configured with a seccompProfile, allowing them to run in Pod Security Admission (PSA) restricted namespaces.
Changes:
- Add
gateways.seccompProfile: { type: RuntimeDefault }to the rendered istiod Helm values. - Extend the Istio values configuration structs to support a
gatewaysstanza. - Add a rendering test that asserts the sidecar injector ConfigMap values include the expected
gateways.seccompProfilesetting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pkg/render/istio/istio.go |
Sets default Gateways.SeccompProfile to RuntimeDefault in istiod values to support PSA restricted environments. |
pkg/render/istio/config.go |
Introduces GatewaysConfig and wires it into IstiodOpts so the value is rendered into Helm options. |
pkg/render/istio/istio_test.go |
Adds a test validating the rendered injector ConfigMap contains gateways.seccompProfile.type=RuntimeDefault. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Waypoint proxies to run in PSA restricted mode.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.