Repository navigation
Conversation
tim-kos
changed the title
Node 12 is end of life, and the v1/v2 actions run on Node runtimes GitHub has deprecated for actions. Since CI no longer runs the Node versions the package still supports (>= 4), check that the library stays ES5 instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI only tests Node 12, which reached end of life in 2022. It also uses
actions/checkout@v2andactions/setup-node@v1, which run on Node runtimes GitHub has deprecated for actions.This moves to the v4 actions and tests the supported Node lines: 18, 20, 22 and 24. The test command is unchanged, and the current dev dependencies pass on every version in the matrix.
package.jsonstill promises Node >= 4, which this matrix doesn't run. A separate job parses the library as ES5 with acorn, so syntax that old Node can't run (const, arrow functions, …) fails CI.🤖 Generated with Claude Code