Repository navigation
Conversation
…er timeout as a number Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…forever option Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the inconsistencies reported in #82:
unref: true; it now honors it like the later ones do.foreveroperation used up its timeouts, it passed[lastTimeout](a one-element array) tosetTimeout. That only worked because Node coerces the array to a number. It now passes the number.foreverrestarts from the first timeout, but the operation keeps repeating the last one, which is what the code has always done. The docs now say so.foreveroption thatretry.timeouts()reads, which was undocumented.Behavior change worth a changelog line: a timeout callback that treats its first argument as an error (e.g. a Node-style
(err)callback) used to getundefinedon the first attempt and now gets1. Later attempts already received the attempt number.Each new test fails on
master. They live in their own files, so this doesn't conflict with #98 or #100.Fixes #82
🤖 Generated with Claude Code