Skip to content

chore(deps): bump @types/bcryptjs from 2.4.6 to 3.0.0 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

chore(deps): bump @types/bcryptjs from 2.4.6 to 3.0.0 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"@astrojs/starlight": "0.38.3",
"@types/bcryptjs": "^2.4.6",
"@types/bcryptjs": "^3.0.0",
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read-only verification for bcryptjs typing compatibility signals.

set -euo pipefail

echo "== Locate TypeScript config =="
fd -i 'tsconfig*.json'

echo
echo "== Print compiler interop options (if present) =="
fd -i 'tsconfig*.json' -x sh -c '
  f="$1"
  echo "--- $f ---"
  jq ".compilerOptions | {module, moduleResolution, esModuleInterop, allowSyntheticDefaultImports, types}" "$f" 2>/dev/null || cat "$f"
' sh {}

echo
echo "== Find bcryptjs imports and callsites =="
rg -n -C2 --type=ts --type=tsx '\bfrom\s+["'"'"']bcryptjs["'"'"']|require\(["'"'"']bcryptjs["'"'"']\)|\bbcrypt\.(hash|compare|genSalt)\s*\('

echo
echo "== Confirm dependency entries in package.json =="
jq '.dependencies["bcryptjs"], .dependencies["@types/bcryptjs"]' package.json

Repository: tinyauthapp/docs

Length of output: 376

🏁 Script executed:

#!/bin/bash

echo "== Check if src/lib/create-user.ts exists =="
ls -la src/lib/create-user.ts 2>&1 || echo "File does not exist"

echo
echo "== List src/lib directory =="
ls -la src/lib/ 2>&1 || echo "Directory does not exist"

echo
echo "== Check all bcryptjs references in codebase (any file type) =="
rg 'bcryptjs' -i --no-ignore 2>&1 | head -30

echo
echo "== Check package.json for bcryptjs dependencies =="
cat package.json | grep -A5 -B5 'bcryptjs' 2>&1 || echo "Not found in grep"

echo
echo "== Full dependencies section from package.json =="
jq '.dependencies // {}' package.json 2>/dev/null | head -40

Repository: tinyauthapp/docs

Length of output: 2639

🏁 Script executed:

#!/bin/bash

echo "== Content of src/lib/create-user.ts =="
cat -n src/lib/create-user.ts

echo
echo "== Check astro's strict tsconfig settings =="
# Since tsconfig extends astro/tsconfigs/strict, let's check node_modules
if [ -d "node_modules/astro/tsconfigs" ]; then
  cat node_modules/astro/tsconfigs/strict.json 2>/dev/null || echo "File not found in node_modules"
else
  echo "astro tsconfigs directory not found"
fi

echo
echo "== Check if there's an effective tsconfig in .astro/types.d.ts =="
head -30 .astro/types.d.ts 2>/dev/null || echo "File not accessible"

Repository: tinyauthapp/docs

Length of output: 1324

Confirm @types/bcryptjs v3 compatibility with current imports.

The semver-major bump from @types/bcryptjs@2.4.6 (in package-lock.json) to ^3.0.0 may introduce typing changes. Verify that the default import in src/lib/create-user.ts (import bcrypt from "bcryptjs") and the bcrypt.hash(password, 10) call signature remain properly typed with the new types package.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 14, The bump to `@types/bcryptjs`@^3.0.0 may change the
typing for the default import used in src/lib/create-user.ts; verify that the
line import bcrypt from "bcryptjs" and the call bcrypt.hash(password, 10)
type-check under the new types by running tsc, and if it fails either enable
esModuleInterop / allowSyntheticDefaultImports in tsconfig or switch the import
to the namespace form (import * as bcrypt from "bcryptjs") and ensure
bcrypt.hash(password, 10) matches the declared signature; update
package.json/types or the import/tsconfig accordingly to restore correct typing.

"@types/qrcode": "^1.5.6",
"@yeskunall/astro-umami": "^0.0.8",
"astro": "6.1.8",
Expand Down