Repository navigation
Phase 8: softmax cell, tile dataflow, naive vs flash views - #5
Merged
Merged
Conversation
…flash (L4) Engine readouts: tileDone (one pulse per completed tile) and getDatapath (MM1 and MM2 weights, activations and partial sums, live). Node test checks one completion per FLASH tile and that the running row max never decreases within a row group. L1 (SoftmaxCellView): the engine's row state at each tile completion for a chosen row, against the float softmax of the same INT8 inputs. L2 (TileView): live datapath values, kept from the last busy clock. L4 (CompareView): two engine instances on the same inputs; bytes, cycles, tiles and K/V loads measured; footprint and occupancy as labelled formulas; error grids against float; an N sweep (4 to 32) of HBM bytes on seeded inputs. Layout: level tabs over the schedule view. Fixes found by the new checks: output values printed as raw floats overflowed at 375 px; tile grids overhung by 1 px. Playwright: 12 tests (all views at 375 px, the light and dark colour schemes, the NAIVE message). Vitest: 15 tests. Docs: ARCHITECTURE section 13, STATE_SCHEMA, PLAN, CONTEXT, README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 8: the remaining levels of the visualizer.
tileDoneandgetDatapath(). No change to the datapath logic.Verification
pnpm test:e2e(Playwright, production build): 12 passed. All four views at 375 px, the light and dark colour schemes, the NAIVE message.pnpm test(Vitest): 15 passed.node wasm/test.mjs: PASS, including one completion per FLASH tile and a non-decreasing row max within each group.SEEDS=1 bash sim/run_e2e.sh: 3/3 passed (the full 200-seed sweep passed on main before this branch).bash sim/lint.sh,pnpm lint,pnpm typecheck,pnpm build: clean.Notes
runToDonerather than a separaterunFast.