Conversation
|
Warning Review limit reached
This review includes 5 billable files and costs up to $1.25. Or wait 38 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Comment |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 3 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. Findings
Could not review: Cargo.toml, crates/tinyjuice-module/Cargo.toml, crates/tinyjuice-module/src/lib.rs, crates/tinyjuice-module/src/service.rs Before merge
How this fits togetherflowchart LR
n0["setup<br/>changed<br/>1 finding"]:::flagged
n1["call"]:::impacted
n2["compress"]:::impacted
n3["service_compresses_and_retrieves_a_large_log"]:::impacted
n4["llm"]:::impacted
n5["install"]:::impacted
n0 -->|calls| n1
n0 -->|uses| n4
n3 -->|calls| n2
n3 -->|tests| n2
n3 -->|calls| n5
n3 -->|tests| n5
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: Cargo.toml, crates/tinyjuice-module/Cargo.toml, crates/tinyjuice-module/src/lib.rs, crates/tinyjuice-module/src/service.rs.
$0.0051 · 45,367 in / 14,361 out · 21,248 cached (47%) · ladder/vectors, deepseek/deepseek-v4-flash · 151 embedded
tests: $0.0020 · 25,927 in / 4,031 out · 15,360 cached (59%) · deepseek/deepseek-v4-flash
description: $0.0008 · 3,800 in / 3,564 out · 2,304 cached (61%) · deepseek/deepseek-v4-flash
e2e: $0.0016 · 13,190 in / 3,408 out · 3,072 cached (23%) · deepseek/deepseek-v4-flash
| #[allow(missing_docs, unreachable_pub)] | ||
| mod exports { | ||
| tinybus_module::module_export! { | ||
| tinybus_module::module_export_optional_static! { |
There was a problem hiding this comment.
Add a test that exercises the static-link feature
The change introduces a static-link feature that conditionally exports a linked_module symbol via the module_export_optional_static! macro. No test enables this feature or verifies the symbol is correctly generated. If the macro is misused or the vendored crate changes, a regression could go undetected until someone actually uses the feature and encounters a compile/link error. Add a test that enables features = ["static-link"] and calls linked_module() (or at least verifies the symbol compiles).
[RULE] missing-test ·
|
|
||
| mod service; | ||
|
|
||
| #[cfg(feature = "static-link")] |
There was a problem hiding this comment.
Add end-to-end coverage for the static-link feature's linked_module export
The new linked_module public function, gated behind the static-link feature, is an external surface that no end-to-end test exercises. The only end-to-end test (crates/tinyjuice-module/tests/module_e2e.rs) tests the dynamic-loading path without enabling the static-link feature. A regression in the static-linking path would go undetected.
[RULE] e2e-uncovered ·
Summary
tinyjuice-module/static-linkusing TinyBusmodule_export_optional_static!, which selects dynamic exports by default and a Rust-addressable module in static builds.tinyjuice_module::linked_module()for direct host registration.433d9edand use=0.1.2registry dependency identities, with local Cargo patches for standalone builds.Related issue
Depends on tinyhumansai/tinybus#29, which builds on merged #28. Ready condition: #29 is merged, this gitlink is reachable from upstream TinyBus, and CI passes. This PR remains a draft until then.
API or behavior changes
Additive public
linked_module()understatic-link. The default loadable module path and wire contract are unchanged.Validation
cargo fmt --manifest-path Cargo.toml --all -- --checkcargo check --manifest-path Cargo.toml -p tinyjuice-module --offlinecargo check --manifest-path Cargo.toml -p tinyjuice-module --features static-link --offlineTests
The two feature builds verify both TinyBus macro expansions and the public root reexport. No runtime behavior changes were added in this package.
Documentation
The feature and root entry point are documented in this PR and by TinyBus #29.
Checklist