Repository navigation
test: rename legacy test.rs and *_test.rs files to *_tests.rs - #36
Merged
Merged
Conversation
Each module keeps its name; its declaration gains a #[path] to the renamed file. Only names change, no test code does. Drops the legacy-files note from the guidance. Co-authored-by: Medulla <medulla@tinyhumans.ai>
…egacy-test-renames
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (83)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughTest-only Rust modules now use explicit source paths across ChangesTest Module Paths
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change only redirects test modules to their renamed source files and removes outdated rename-on-touch guidance. No concrete merge-blocking regression remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
A rabbit checks each test-file door, Comment |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsNo active actionable findings. Could not review: crates/tinymcp-bus/src/agent_tools/mod.rs, crates/tinymcp-bus/src/audit/mod.rs, crates/tinymcp-bus/src/auth/mod.rs, crates/tinymcp-bus/src/config/mod.rs, crates/tinymcp-bus/src/errors/mod.rs, crates/tinymcp-bus/src/method/mod.rs, crates/tinymcp-bus/src/names/mod.rs, crates/tinymcp-bus/src/registry/mod.rs, crates/tinymcp-bus/src/sanitize/mod.rs, crates/tinymcp-bus/src/transport/mod.rs, crates/tinymcp-bus/src/version/mod.rs, crates/tinymcp/src/audit/store/mod.rs, crates/tinymcp/src/config_servers/mod.rs, crates/tinymcp/src/error/mod.rs, crates/tinymcp/src/registry/boot/mod.rs, crates/tinymcp/src/registry/config_doc/mod.rs, crates/tinymcp/src/registry/connections/mod.rs, crates/tinymcp/src/registry/curation/mod.rs, crates/tinymcp/src/registry/oauth/mod.rs, crates/tinymcp/src/registry/ops/mod.rs, crates/tinymcp/src/registry/setup/mod.rs, crates/tinymcp/src/registry/sources/mod.rs, crates/tinymcp/src/registry/sources/official/mod.rs, crates/tinymcp/src/registry/sources/smithery/mod.rs, crates/tinymcp/src/registry/store/mod.rs, crates/tinymcp/src/registry/supervisor/mod.rs, crates/tinymcp/src/server/args/mod.rs, crates/tinymcp/src/server/http/mod.rs, crates/tinymcp/src/server/mod.rs, crates/tinymcp/src/server/protocol/mod.rs, crates/tinymcp/src/server/session/mod.rs, crates/tinymcp/src/server/stdio/mod.rs, crates/tinymcp/src/tinybus_module/directories/mod.rs, crates/tinymcp/src/tinybus_module/maintenance/mod.rs, crates/tinymcp/src/tinybus_module/mod.rs, crates/tinymcp/src/tools/mod.rs, crates/tinymcp/src/transport/http/mod.rs, crates/tinymcp/src/transport/mod.rs, crates/tinymcp/src/transport/stdio/mod.rs, crates/tinymcp/src/transport/stdio/spawn_env/mod.rs, tinysweeper/description, tinysweeper/tests Before merge
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinymcp-bus/src/agent_tools/mod.rs, crates/tinymcp-bus/src/audit/mod.rs, crates/tinymcp-bus/src/auth/mod.rs, crates/tinymcp-bus/src/config/mod.rs, crates/tinymcp-bus/src/errors/mod.rs, crates/tinymcp-bus/src/method/mod.rs, crates/tinymcp-bus/src/names/mod.rs, crates/tinymcp-bus/src/registry/mod.rs and 34 more.
$0.0000 · 0 in / 0 out · 687 embedded · ladder/vectors
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames 42 legacy test files (
test.rsand<name>_test.rs) to<module>_tests.rs(test.rsbecomes<declaring file>_tests.rs,mod_tests.rsbeside amod.rs). Each module keeps its identifier, so references to it keep resolving; its declaration gains a#[path]to the renamed file. Only file names and those attributes change, no test code. Removes the now-stale "legacy files" note from the guidance. Done with OpenHuman'sscripts/externalize-inline-tests.mjs --rename-legacy.Related issue
None.
API or behavior changes
None. Test-only files renamed; no public API or runtime behavior changes.
Validation
Commands actually run, with their outcome:
cargo fmt --all -- --check(clean)cargo clippy --all-targets --all-features -- -D warnings(left to CI)cargo check --workspace --tests(passes;cargo build/cargo testleft to CI)cargo test --all-features(left to CI)Tests
No tests added or changed; 42 files renamed. Test bodies are untouched (git detects them as renames).
Documentation
CLAUDE.md/AGENTS.mdupdated.Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the descriptionSummary by CodeRabbit