chore: refresh TinyBus and TinyInference for OpenHuman module - #160
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
# Conflicts: # Cargo.lock
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (18)
Comment |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Changes requested Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. Findings
Resolved this pass
Before merge
How this fits togetherflowchart LR
n0["...ng_settings_local_overrides_memory_config<br/>changed"]:::changed
n1["...tings_local_with_empty_model_uses_default<br/>changed"]:::changed
n2["start_mock_ollama<br/>changed"]:::changed
n3["TestChatHost<br/>changed"]:::changed
n4["effective_embedding_settings"]:::impacted
n5["ChatHost"]:::impacted
n6["Result"]:::impacted
n7["effective_embedding_settings_probed"]:::impacted
n8["...settings_keep_ollama_when_daemon_responds"]:::impacted
n0 -->|calls| n4
n0 -->|tests| n4
n1 -->|calls| n4
n1 -->|tests| n4
n3 -->|implements| n5
n5 -->|uses| n6
n7 -->|calls| n4
n8 -->|calls| n2
n8 -->|tests| n2
n8 -->|calls| n7
n8 -->|tests| n7
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0178 · 695,302 in / 23,870 out · 41,118 cached (6%) · flash, ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 741 embedded
critique: $0.0086 · 335,024 in / 8,477 out · 20,669 cached (6%) · gpt-5.6-luna, deepseek-v4-flash
security: $0.0078 · 307,278 in / 6,078 out · 16,353 cached (5%) · gpt-5.6-luna
tests: $0.0004 · 17,207 in / 1,977 out · 1,536 cached (9%) · deepseek-v4-flash
description: $0.0002 · 7,657 in / 1,946 out · 1,024 cached (13%) · deepseek-v4-flash
e2e: $0.0003 · 17,735 in / 789 out · 1,536 cached (9%) · deepseek-v4-flash
There was a problem hiding this comment.
Requesting changes: 1 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0191 · 802,120 in / 27,522 out · 113,373 cached (14%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 741 embedded
critique: $0.0100 · 406,297 in / 12,560 out · 45,652 cached (11%) · gpt-5.6-luna, deepseek-v4-flash
security: $0.0083 · 342,825 in / 6,537 out · 38,025 cached (11%) · gpt-5.6-luna
tests: $0.0002 · 18,260 in / 2,081 out · 11,264 cached (62%) · deepseek-v4-flash
description: $0.0002 · 8,710 in / 1,971 out · 2,048 cached (24%) · deepseek-v4-flash
e2e: $0.0002 · 18,788 in / 1,026 out · 11,264 cached (60%) · deepseek-v4-flash
| tinycortex = { version = "0.1", features = ["contacts"] } | ||
| # Provider-neutral chat request and response types carried over TinyBus. | ||
| tinyinference = "0.2" | ||
| tinyinference-llm = "0.3" |
There was a problem hiding this comment.
Update the module lockfile for the renamed dependency
This standalone workspace has its own committed crates/tinymemory-module/Cargo.lock, and changing the direct dependency from tinyinference to tinyinference-llm changes the resolved package graph. The lockfile must be regenerated and committed with this manifest; otherwise locked/reproducible builds can reject the manifest or silently rewrite the lockfile.
[RULE] stale-lockfile ·
| # both crates share one trait identity. | ||
| [patch."https://github.com/tinyhumansai/tinyinference"] | ||
| tinyinference = { path = "vendor/tinyinference/crates/tinyinference" } | ||
| tinyinference-core = { path = "vendor/tinyinference/crates/tinyinference-core" } |
There was a problem hiding this comment.
Regenerate the root lockfile for the split TinyInference crates
This changes the patched package set and their resolved sources from the old tinyinference package to three path packages, but the pull request contains no corresponding Cargo.lock update. With --locked or reproducible CI builds, Cargo can reject the manifest as inconsistent or retain the old package/source entries. Regenerate and commit the root lockfile with this manifest change.
[RULE] stale-lockfile ·
| # summarizer and embedding factory. Agent runtime and session behavior do not | ||
| # belong in the memory layer. | ||
| tinyinference = "0.2" | ||
| tinyinference-embeddings = "0.3" |
There was a problem hiding this comment.
Commit the updated lockfiles for the renamed dependencies
Changing the direct dependency from tinyinference to tinyinference-embeddings and tinyinference-llm invalidates the committed Cargo.lock files. The root Cargo.lock and crates/tinymemory-module/Cargo.lock must be regenerated (e.g. cargo generate-lockfile in each workspace) and committed together with this manifest change. Without them, locked/reproducible builds will reject the manifest as inconsistent, and the lockfile will otherwise be silently rewritten on the next cargo update.
Additional critique observation
Regenerate the workspace lockfile for the split dependencies
[RULE] stale-lockfile
Replacing tinyinference with these two direct dependencies changes the tinymemory-core package dependency list recorded in the committed workspace Cargo.lock. Because that lockfile is not part of this change, cargo check --locked and other reproducible builds will reject the manifest as inconsistent (and an unlocked build will silently rewrite the lockfile). Regenerate and commit the workspace lockfile with this manifest change.
[RULE] stale-lockfile ·
Summary
Merge upstream main into OpenHuman's pinned TinyMemory branch, preserving its existing split-inference changes. Refresh the vendored TinyBus and TinyInference revisions, update the split inference dependency requirements to 0.3, and regenerate Cargo.lock. This prepares a new TinyMemory module release for OpenHuman.
Related issue
None.
API or behavior changes
The existing split inference work on the pinned branch becomes part of the next TinyMemory release. The module builds against the latest TinyBus and TinyInference main revisions.
Validation
cargo check --manifest-path vendor/tinymemory/Cargo.toml --quietfrom OpenHuman's worktreeTests
No new tests added. The release workflow runs the module suite and platform builds.
Documentation
No new public contract; the dependency and source pins are updated.
Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the descriptionSummary by CodeRabbit