Install rustfmt and clippy with pinned Rust by senamakel · Pull Request #163 · tinyhumansai/tinymemory

senamakel · 2026-09-24T16:57:51Z

Follow-up to #162: the initial toolchain pin merged while CI was still running. Its minimal profile omitted rustfmt, causing the formatting check to fail. This adds rustfmt and clippy to the pinned 1.96.1 toolchain.

Summary by CodeRabbit

Chores
- Updated development tooling configuration to include Rust formatting and linting tools.
- Adjusted a lint setting. These changes do not affect application behavior or add user-facing features.

coderabbitai · 2026-09-24T16:58:00Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

Run on-demand review

_{This review includes 1 billable file and costs up to $0.25.}

Or wait 40 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a043e7b2-d2a0-4c98-959c-b0badb0f44a0

📥 Commits

Reviewing files that changed from the base of the PR and between 8f509fa and 58a71eb.

📒 Files selected for processing (1)

.github/workflows/ci.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 45176220-34e4-4410-b91c-b80b26650186

📥 Commits

Reviewing files that changed from the base of the PR and between b57b0ab and 8f509fa.

📒 Files selected for processing (2)

crates/tinymemory-module/src/service/mod.rs
rust-toolchain.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The toolchain configuration now requests rustfmt and clippy. The override_scheduler_gate lint attribute now suppresses only clippy::unused_async.

Changes

Rust lint tooling

Layer / File(s)	Summary
Lint and toolchain setup `rust-toolchain.toml`, `crates/tinymemory-module/src/service/mod.rs`	The toolchain configuration adds `rustfmt` and `clippy`. The lint attribute on `override_scheduler_gate` removes `clippy::unused_async_trait_impl` from its suppression list.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Suggested reviewers: yellowsnnowmann

Merge Risk: ⚪ Minimal · up to 8f509

The change adds the formatting and linting components used by CI without introducing a new Clippy failure. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main changes: adding rustfmt and clippy to the pinned Rust toolchain.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{A rabbit checks the linting list,
And finds two tools now on the roster.
One warning stays, one leaves the list,
The code keeps hopping as it was.
A tidy burrow, bright and fast!}

_{Comment @coderabbitai help to get the list of available commands.}

tinysweeper · 2026-09-24T17:18:55Z

Tiny Sweeper review

Tiny Sweeper reviewed this pull request across 6 lanes and found 0 active findings. The change pins rustfmt and clippy with the toolchain, refactors the MSRV CI command, and removes an unnecessary clippy allow.

State: Ready for maintainer review
Priority: none
Reviewed head: 58a71eb79a4e
Updated: 1790272288 (Unix time)

Review snapshot

Change surface	Files	Review signal
Production	1	Active findings
Tests	0	Noted findings
Documentation	0	Resolved findings
Configuration	2	Pending checks/questions

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

Adds components = ['rustfmt', 'clippy'] to rust-toolchain.toml to pin these tools with the 1.96.1 toolchain. Refactors the MSRV build command in .github/workflows/ci.yml to use an environment variable for clarity and safety. Removes the clippy::unused_async_trait_impl allow from crates/tinymemory-module/src/service/mod.rs, retaining only clippy::unused_async.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["MemoryService<br/>changed"]:::changed
  n1["...ed_and_only_success_counts_toward_the_cap"]:::impacted
  n2["test_provider"]:::impacted
  n3["...e_cap_is_reached_through_successful_opens"]:::impacted
  n4["...store_opens_under_the_one_workspace_queue"]:::impacted
  n5["...nt_opens_reuse_the_registered_object_path"]:::impacted
  n6["...pens_a_window_that_outranks_a_paused_gate"]:::impacted
  n1 -->|uses| n0
  n1 -->|calls| n2
  n1 -->|tests| n2
  n3 -->|uses| n0
  n3 -->|calls| n2
  n3 -->|tests| n2
  n4 -->|uses| n0
  n4 -->|calls| n2
  n4 -->|tests| n2
  n5 -->|uses| n0
  n5 -->|calls| n2
  n5 -->|tests| n2
  n6 -->|uses| n0
  n6 -->|calls| n2
  n6 -->|tests| n2
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff

Agent review details

critique

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: Reviewed 3 files; 0 findings. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

security

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: Reviewed 3 files; 0 findings. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

tests

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: This pull request adjusts the CI MSRV command quoting, prunes an unnecessary clippy allow, and pins rustfmt/clippy as toolchain components. No behavioural changes that could silently regress — the diff is safe to merge without new tests. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

commits

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: Nothing sensitive found in what this pull request commits.

description

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: Adds rustfmt and clippy to the pinned 1.96.1 toolchain, removes an unnecessary clippy allow attribute, and refactors a CI MSRV command to use an environment variable. No defects are introduced. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

e2e

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The pull request modifies only CI infrastructure (how MSRV is passed, a toolchain component list) and a clippy lint suppression — none of these changes have an external surface that an end-to-end test would cover. The CI jobs passed, and no test coverage gap was introduced. 2 end-to-end jobs passed on this head. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

Evidence and run details

Models: ladder/vectors, gpt-5.6-luna, deepseek-v4-flash
Spend: $0.003293
Tokens: 135661 input · 6090 output · 7715 cached · 99 embedding

Head	State	Pass summary
`8f509fac64c8`	ready for maintainer review	0 active finding(s), 0 resolved finding(s) (at 1790270441)
`58a71eb79a4e`	ready for maintainer review	0 active finding(s), 0 resolved finding(s) (at 1790270660)
`58a71eb79a4e`	ready for maintainer review	0 active finding(s), 0 resolved finding(s) (at 1790272288)

tinysweeper

tinysweeper found nothing blocking. Approving.

             $0.0014 · 58,748 in / 7,698 out · 7,984 cached (14%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 99 embedded
critique:    $0.0003 · 12,732 in / 335 out   · 2,066 cached (16%) · gpt-5.6-luna
security:    $0.0003 · 12,488 in / 191 out   · 1,822 cached (15%) · gpt-5.6-luna
tests:       $0.0003 · 13,406 in / 1,220 out · 1,536 cached (11%) · deepseek-v4-flash
description: $0.0001 · 3,765 in  / 2,521 out · 1,024 cached (27%) · deepseek-v4-flash
e2e:         $0.0003 · 14,236 in / 447 out   · 1,536 cached (11%) · deepseek-v4-flash

senamakel added 2 commits September 24, 2026 22:26

ci: install formatting and lint components for pinned Rust

8d1fbe3

Merge remote-tracking branch 'origin/main' into fix-module-rustc-skew

835af2d

fix: keep memory module Clippy lint compatible with pinned Rust

8f509fa

coderabbitai Bot approved these changes Sep 24, 2026

View reviewed changes

ci: pass the MSRV to the shell as data

58a71eb

tinysweeper Bot approved these changes Sep 24, 2026

View reviewed changes

tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 24, 2026

senamakel merged commit 613d9f8 into tinyhumansai:main Sep 24, 2026
30 checks passed

Navigation Menu

Install rustfmt and clippy with pinned Rust - #163

Install rustfmt and clippy with pinned Rust#163
senamakel merged 4 commits into
tinyhumansai:mainfrom
senamakel:fix-module-rustc-skew

senamakel commented Sep 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 24, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

tinysweeper Bot commented Sep 24, 2026 •

edited

Loading

critique

security

tests

commits

description

e2e

Uh oh!

tinysweeper Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

senamakel commented Sep 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

tinysweeper Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tiny Sweeper review

Review snapshot

What changed

Features

Tests

Findings

Before merge

How this fits together

critique

security

tests

commits

description

e2e

Uh oh!

tinysweeper Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

senamakel commented Sep 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 24, 2026 •

edited

Loading

tinysweeper Bot commented Sep 24, 2026 •

edited

Loading