Skip to content

fix: include rustfmt and clippy in pinned toolchain #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 2 commits into from
Sep 24, 2026
+2 −1
Merged

fix: include rustfmt and clippy in pinned toolchain #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e00a2
fix: install formatting tools for pinned release toolchain
senamakel Sep 24, 2026
03d44f3
fix: remove unavailable Clippy lint from module
senamakel Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/tinymemory-module/src/service/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2241,7 +2241,7 @@ impl MemoryService {
// async only for the interface macro's member contract — the body is one
// synchronous global write, and that is the point: a claim's step-0 read
// must never wait on this.
#[allow(clippy::unused_async, clippy::unused_async_trait_impl)]
#[allow(clippy::unused_async)]
async fn override_scheduler_gate(&self, seconds: u64) -> BusResult<()> {
// Clamp: a window longer than an hour is the gate turned off with
// extra steps, which is the config's job, not this member's.
Expand Down
1 change: 1 addition & 0 deletions rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[toolchain]
channel = "1.96.1"
profile = "minimal"
components = ["rustfmt", "clippy"]

@tinysweeper tinysweeper Bot Sep 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

priority medium security confident

Install llvm-tools-preview for coverage checks

The repository's CI installs and runs cargo-llvm-cov, which requires the llvm-tools-preview rustup component. Because this toolchain configuration uses an explicit component list, fresh checkouts will not receive it and coverage jobs can fail with a missing-component error. Add llvm-tools-preview to the list.

Additional critique observation

priority medium confident

Install the LLVM tools required by coverage checks

[RULE] missing-toolchain-components

The repository's CI installs llvm-tools-preview alongside rustfmt and clippy before running cargo-llvm-cov. A fresh checkout using this toolchain file still lacks that component, so coverage commands can fail with a missing-component error. Add llvm-tools-preview to the component list.

Suggested change for this observation (reference only)

components = ["rustfmt", "clippy", "llvm-tools-preview"]

Suggested change for the opening observation

Suggested change
components = ["rustfmt", "clippy"]
components = ["rustfmt", "clippy", "llvm-tools-preview"]

[RULE] missing-toolchain-components ·

Loading