test: rename legacy test.rs and *_test.rs files to *_tests.rs - #43
Conversation
Each module keeps its name; its declaration gains a #[path] to the renamed file. Only names change, no test code does. Drops the legacy-files note from the guidance. Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsNo active actionable findings. Could not review: crates/tinytools-agent/src/codecall/mod.rs, crates/tinytools-agent/src/dialect/mod.rs, crates/tinytools-agent/src/parse/protected.rs, crates/tinytools-agent/src/pformat.rs, crates/tinytools-agent/src/render/results.rs, crates/tinytools-agent/src/stream/mod.rs, crates/tinytools-jev/src/lib.rs, crates/tinytools-std/src/detect_tools/mod.rs, crates/tinytools-std/src/filesystem/apply_patch/mod.rs, crates/tinytools-std/src/filesystem/csv_export/mod.rs, crates/tinytools-std/src/filesystem/edit_file/mod.rs, crates/tinytools-std/src/filesystem/file_read/mod.rs, crates/tinytools-std/src/filesystem/file_write/mod.rs, crates/tinytools-std/src/filesystem/git_operations/mod.rs, crates/tinytools-std/src/filesystem/glob_search/mod.rs, crates/tinytools-std/src/filesystem/grep/mod.rs, crates/tinytools-std/src/filesystem/image_info/mod.rs, crates/tinytools-std/src/filesystem/list_files/mod.rs, crates/tinytools-std/src/filesystem/mod.rs, crates/tinytools-std/src/filesystem/read_diff/mod.rs, crates/tinytools-std/src/filesystem/run_linter/mod.rs, crates/tinytools-std/src/filesystem/run_tests/mod.rs, crates/tinytools-std/src/filesystem/update_memory_md/mod.rs, crates/tinytools-std/src/filesystem/workspace_state/mod.rs, crates/tinytools-std/src/network/curl.rs, crates/tinytools-std/src/network/http_request.rs, crates/tinytools-std/src/network/mod.rs, crates/tinytools-std/src/network/pushover.rs, crates/tinytools-std/src/network/web_fetch.rs, crates/tinytools-std/src/url_guard/mod.rs, crates/tinytools/src/call/mod.rs, crates/tinytools/src/classification/mod.rs, crates/tinytools/src/collapse/mod.rs, crates/tinytools/src/command_output/mod.rs, crates/tinytools/src/context/mod.rs, crates/tinytools/src/deferral/mod.rs, crates/tinytools/src/naming/mod.rs, crates/tinytools/src/permission/mod.rs, crates/tinytools/src/policy/mod.rs, crates/tinytools/src/rank/mod.rs, crates/tinytools/src/result/mod.rs, crates/tinytools/src/spec/mod.rs, crates/tinytools/src/tool/mod.rs, crates/tinytools/src/workspace/mod.rs, tinysweeper/description, tinysweeper/tests Before merge
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (98)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes remove the AGENTS.md exception for legacy Rust test filenames and add or update explicit ChangesTest module path convention
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change renames test files and points test module declarations at them. It does not change runtime behavior, and the author reports that the workspace test build compiles. No merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
A rabbit hops through files so neat, Comment |
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinytools-agent/src/codecall/mod.rs, crates/tinytools-agent/src/dialect/mod.rs, crates/tinytools-agent/src/parse/protected.rs, crates/tinytools-agent/src/pformat.rs, crates/tinytools-agent/src/render/results.rs, crates/tinytools-agent/src/stream/mod.rs, crates/tinytools-jev/src/lib.rs, crates/tinytools-std/src/detect_tools/mod.rs and 38 more.
$0.0000 · 0 in / 0 out · 773 embedded · ladder/vectors
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd5b92a7b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| #[cfg(test)] | ||
| #[path = "test.rs"] | ||
| #[path = "mod_tests.rs"] |
There was a problem hiding this comment.
This rename makes dialect/mod_tests.rs a *_tests.rs file, but it still begins with a lint attribute rather than a //! description. The same omission occurs in 12 other renamed files, including pformat_tests.rs, render/results_tests.rs, several tinytools-std filesystem/network test files, and tinytools/src/rank/mod_tests.rs; add concise module-level documentation to every newly renamed test file.
AGENTS.md reference: AGENTS.md:L202-L203
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
Renames 53 legacy test files (
test.rsand<name>_test.rs) to<module>_tests.rs(test.rsbecomes<declaring file>_tests.rs,mod_tests.rsbeside amod.rs). Each module keeps its identifier, so references to it keep resolving; its declaration gains a#[path]to the renamed file. Only file names and those attributes change, no test code. Removes the now-stale "legacy files" note from the guidance. Done with OpenHuman'sscripts/externalize-inline-tests.mjs --rename-legacy.Related issue
None.
API or behavior changes
None. Test-only files renamed; no public API or runtime behavior changes.
Validation
Commands actually run, with their outcome:
cargo fmt --all -- --check(clean)cargo clippy --all-targets --all-features -- -D warnings(left to CI)cargo check --workspace --tests(passes;cargo build/cargo testleft to CI)cargo test --all-features(left to CI)Tests
No tests added or changed; 53 files renamed. Test bodies are untouched (git detects them as renames).
Documentation
CLAUDE.md/AGENTS.mdupdated.Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the descriptionSummary by CodeRabbit