Skip to content

build: align tinybus dependency (range, nested 0.1.5) - #43

Merged
senamakel merged 1 commit into
mainfrom
tinybus-align
Oct 13, 2026
Merged

senamakel merged 1 commit into
mainfrom
tinybus-align

Conversation

@senamakel

@senamakel senamakel commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Part of tinyhumansai/openhuman#7610, #7543, #7523

Summary by CodeRabbit

  • Maintenance
    • Updated compatibility with supported Tinybus versions. This may make it easier to use Tinyvoice alongside newer compatible Tinybus releases; no user-facing features or behavior changes are included.

Replace the crates.io tinybus dependency with a vendored copy under
vendor/tinybus so the module builds against the local source.

Auto-committed-on: dragonfly
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T17:53:20.715700Z acc8afc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b1666189-b914-4756-9092-bf18053e9fe5
📥 Commits

Reviewing files that changed from the base of the PR and between b9de772 and acc8afc.

⛔ Files ignored due to path filters (1)
  • crates/tinyvoice-module/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/tinyvoice-module/Cargo.toml
  • vendor/tinybus
 ______________________________________________
< Your code is my code, your bugs are my bugs. >
 ----------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit bbbd861 into main Oct 13, 2026
13 of 14 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acc8afca6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vendor/tinybus
@@ -1 +1 @@
Subproject commit 10579d486f276c78c9c4a2b5eaa8bfee0e302292
Subproject commit eb5cf727071a6eb12f9efa3db8ec59e54039f336

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Isolate the TinyBus gitlink update

This commit updates the vendored TinyBus gitlink together with Cargo.toml and Cargo.lock, contrary to the repository requirement that TinyBus gitlink updates be made in a separate commit. Isolate the gitlink bump so the vendored revision can be reviewed and reverted independently from dependency-resolution changes.

AGENTS.md reference: AGENTS.md:L149-L152

Useful? React with 👍 / 👎.

@tinysweeper

tinysweeper Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: acc8afca6f9c
Updated: 2026-10-13T23:28:06Z

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The diff relaxes the pinned exact version requirements for `tinybus` and `tinybus-module` from `=0.1.3` to `>=0.1.3, <0.2` in the module's manifest. The repository rule states "Pin dependency caret ranges (serde = "1"), not exact versions", which this change moves toward, and no other file in the tree appears to depend on the exact-version form (the version-bump script and release test only touch the `tinyvoice` path dependency). The one thing I could not check is the vendored `vendor/tinybus` submodule, which is not checked out here, so I cannot verify what versions actually exist within the `<0.2` range or whether the module depends on `tinybus`/`tinybus-module` internals that are not semver-stable across minor releases; the committed `Cargo.lock` still records the 0.1.3 resolution. I am submitting this as a provisional verdict with no lookups available to resolve that gap. _The code index is behind this pull request (indexed at `e1a950cf4bf8`), so retrieved context may be out of date._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The diff widens the pinned vendored TinyBus dependency requirements from exact `=0.1.3` to a `>=0.1.3, <0.2` caret-style range, which is a dependency-pinning loosening rather than an input-handling or auth change. It does not introduce a concrete reachable defect in this file: no new code path, network call, or deserialization is added, and the Cargo.lock (separate file) governs what actually builds. Nothing reportable in `crates/tinyvoice-module/Cargo.toml`. _The code index is behind this pull request (indexed at `e1a950cf4bf8`), so retrieved context may be out of date._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The diff widens two TinyBus dependency requirements from exact pins (`=0.1.3`) to caret-style ranges (`>=0.1.3, <0.2`) in crates/tinyvoice-module/Cargo.toml:39 and :41, which matches the stated intent of aligning the dependency so the vendored 0.1.5 can be selected. No findings to raise. _The code index is behind this pull request (indexed at `e1a950cf4bf8`), so retrieved context may be out of date._
Evidence and run details
  • Models: ladder/vectors-oai3, deepseek-v4.1-flash
  • Spend: $0.000182
  • Tokens: 69534 input · 2269 output · 12800 cached · 58 embedding
Head State Pass summary
acc8afca6f9c ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-13T23:28:06Z)

tinysweeper 0.1.2

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0002 · 69,534 in / 2,269 out · 12,800 cached (18%) · ladder/vectors-oai3, deepseek-v4.1-flash · 58 embedded
critique:    $0.0000 · 27,597 in / 542 out   · 4,096 cached (15%)  · deepseek-v4.1-flash
security:    $0.0000 · 29,606 in / 414 out   · 3,712 cached (13%)  · deepseek-v4.1-flash
description: $0.0000 · 10,543 in / 311 out   · 4,992 cached (47%)  · deepseek-v4.1-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant