TINYDOC-3554 - Fix Angular cloud docs: remove license key/self-hosted content#4274
Open
kemister85 wants to merge 1 commit into
Open
TINYDOC-3554 - Fix Angular cloud docs: remove license key/self-hosted content#4274kemister85 wants to merge 1 commit into
kemister85 wants to merge 1 commit into
Conversation
…y only Remove licenseKey="gpl" from the cloud-gated component sample and gate the self-hosted loading include (angular-load-tinymce-independently.adoc) behind productSource != cloud, so the Angular cloud page loads exclusively via the API key and no longer shows self-hosted setup steps. Matches the React and Vue cloud pages. Package-manager and zip pages are unaffected.
kemister85
requested review from
a team,
MitchC1999,
TheSpyder,
kimwoodfield and
tiny-ben-tran
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: TINYDOC-3554
Site: Staging branch
Changes:
Fixes the Angular cloud quick-start so that, like the React and Vue cloud pages, {productname} loads exclusively via the API key.
licenseKey="gpl"from the cloud-gated (ifeval::["{productSource}" == "cloud"]) component sample inmodules/ROOT/partials/integrations/angular-quick-start.adoc. The cloud sample now usesapiKey="no-api-key"only.angular-load-tinymce-independently.adoc) behindifeval::["{productSource}" != "cloud"], so the self-hosted setup steps (TINYMCE_SCRIPT_SRClazy-loading,angular.jsonassets,base_url/suffix) no longer leak onto the cloud page.The partial is shared by the cloud, package-manager, and zip Angular pages; both changes are scoped to the cloud variant. The
angular-pmandangular-zippages are unaffected — verified in the local build that both still renderlicenseKey="gpl"and the full self-hosted setup.Note on other versions: the
tinymce/5,tinymce/6, andtinymce/7Angular partials were checked and do not contain this defect (nolicenseKeyin the cloud sample; self-hosted content already correctly gated), so no backport is required.Pre-checks:
hotfix/8/TINYDOC-3554Review: