Add ProbeProgressCallback constructor overloads to Scanner base class#154
Merged
Add ProbeProgressCallback constructor overloads to Scanner base class#154
Conversation
Passing null to a constructor that takes a ProbeProgressCallback is a caller error; defensively shielding against it duplicates the existing null-coalescing in ThreadedScanJobExecutor.setProgressCallback and adds no value. Restructure the no-arg / no-callback ctors to stand on their own (instead of delegating through a null cast), and let the callback ctors set the field unconditionally. Drops testConstructorWithNullCallbackScansSuccessfully — it only existed to verify the guard we are removing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ic0ns
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ProbeProgressCallback constructor overloads to Scanner base class