Repository navigation
Unblock release pipeline: Android Gradle cache + detector history window - #5
Merged
Merged
Conversation
… window) The Release workflow has never published: the Android job died in setup-java because `cache: gradle` hashes Gradle files that do not exist until prebuild, and since August the shared test step fails on a detector test. - android.yml: cache ~/.gradle with actions/cache keyed on the lockfile and app.json instead of setup-java's built-in Gradle cache. - detectors: anchor the 21-day history window on the localDate being evaluated rather than Date.now(), so a run for a past day still sees its own history. This is what made 'raises confidence when the pattern recurs' start failing once the wall clock moved 21 days past the fixture dates. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
'applies the choice to memory immediately' fired setPreference and returned
while its storage write was still behind an in-flight dynamic import. On a
loaded runner the one-macrotask drain in beforeEach is not enough, the import
overlaps the next test's, and Vitest resolves that second import to the real
async-storage module ('window is not defined', swallowed by the store) — so
'persists the choice under the documented key' never sees its write. The test
now waits for its own write before finishing. Reproduced at ~7% under CPU
load before, 0/40 after.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow has never published a release. Two independent causes:
setup-java.cache: gradlehashes*.gradlefiles at setup time, butandroid/is generated byexpo prebuildlater, so the step errors with "No file ... matched". Replaced withactions/cacheon~/.gradle, keyed onpnpm-lock.yaml+app.json.pnpm testfails on both platforms since August.runDetectorstakes an explicitlocalDatebut fetched history relative toDate.now(). The fixture dates (2026-07-09..11) fell outside the 21-day window once the wall clock passed them, sopossible_meal › raises confidence when the pattern recursgot no history. The window is now anchored on thelocalDatebeing evaluated.Local:
pnpm checkpasses (shared 214, mobile 116, api 118 tests).🤖 Generated with Claude Code