Skip to content

Release menu repeat controls and bound disabled-item navigation #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toZyn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Release menu repeat controls and bound disabled-item navigation #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion tests/engine/gameplay-flow.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
check('quick menu taps move once and accept the selected item', function()
for _, navigation in ipairs({{'vertical', 's'}, {'horizontal', 'd'}}) do
local throttleCount = #Throttle.list
local menu = MenuList(nil, false, navigation[1])
for _ = 1, 3 do menu:add(Sprite()) end
controls:onKeyPress(navigation[2])
Expand All @@ -19,11 +20,48 @@ check('quick menu taps move once and accept the selected item', function()
controls:update()
menu:update(0.016)
assert(selected == menu.members[2] and calls == 1, 'a quick accept tap did not select the second item')
for _, throttle in pairs(menu.throttles) do throttle:destroy() end
menu:destroy()
assert(#Throttle.list == throttleCount, 'destroyed menu retained its repeat controls')
end
end)

check('menu owners release named repeat controls on leaving', function()
for _, path in ipairs({'funkin.states.mainmenu', 'funkin.states.freeplay',
'funkin.states.storymenu', 'funkin.states.credits', 'funkin.states.mods',
'funkin.ui.options', 'funkin.ui.editor.editormenu'}) do
local class = require(path)
local count = #Throttle.list
local script = Script('tests/engine/compat-fixture.lua', false, true, true)
local owner = setmetatable({script = script, grpText = SpriteGroup(), grpIcon = SpriteGroup(),
throttles = {up = Throttle:make({function() return false end}),
down = Throttle:make({function() return false end})}}, class)
assert(type(owner.leave) == 'function', path .. ' has no cleanup hook')
owner:leave()
assert(#Throttle.list == count, path .. ' retained repeat controls after leaving')
assert(not owner.throttles or next(owner.throttles) == nil, path .. ' retained recycled controls')
script:close()
owner.grpText:destroy(); owner.grpIcon:destroy()
end
end)

check('a fully disabled menu cannot hang navigation or accept', function()
local menu = MenuList(nil, false, 'vertical')
for _ = 1, 3 do menu:add(Sprite()) end
for _, item in ipairs(menu.members) do item.unselectable = true end
local selected = menu.curSelected
debug.sethook(function() error('disabled menu navigation did not terminate') end, '', 10000)
local ok, message = pcall(menu.changeSelection, menu, 1)
debug.sethook()
assert(ok, message)
assert(menu.curSelected == selected, 'disabled navigation changed the selection')
local accepted = false
menu.selectCallback = function() accepted = true end
controls:onKeyPress('return'); controls:onKeyRelease('return'); controls:update()
menu:update(0.016)
assert(not accepted, 'a disabled item was accepted')
menu:destroy()
end)

check('keyboard hits, misses and pause preserve a native song and mod HUD', function()
ClientPrefs.data.botplayMode = false
ClientPrefs.data.ghostTap = false
Expand Down
Loading