Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hack/test-external-login.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ rendered="$(
--set controller.externalConfig.host=controller.example \
--set controller.externalConfig.port=6817 \
--set login.enabled=true \
--set-json 'login.readinessProbe={"exec":{"command":["/usr/bin/test","-f","/tmp/ready"]},"periodSeconds":5}' \
--set slurmKeyRef.name=external-auth \
--set slurmKeyRef.key=custom.key \
--show-only templates/login/login-deployment.yaml
)"

for expected in 'key: "custom.key"' 'path: slurm.key'; do
for expected in 'key: "custom.key"' 'path: slurm.key' 'readinessProbe:' '/tmp/ready'; do
if [[ "$rendered" != *"$expected"* ]]; then
printf 'external login render is missing %q\n' "$expected" >&2
exit 1
Expand Down
2 changes: 1 addition & 1 deletion helm/slurm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: slurm
description: Slurm Cluster
type: application
appVersion: "25.11"
version: 1.0.3
version: 1.0.4

annotations:
license: Apache-2.0
Expand Down
4 changes: 4 additions & 0 deletions helm/slurm/templates/login/login-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ spec:
resources:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- with .Values.login.readinessProbe }}
readinessProbe:
{{- toYaml . | nindent 10 }}
{{- end }}
env:
- name: SLURM_CLUSTER_NAME
value: {{ include "slurm.fullname" . }}
Expand Down
4 changes: 4 additions & 0 deletions helm/slurm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,10 @@ login:
# limits:
# cpu: 2
# memory: 4Gi
#
# -- (object)
# Configure the login container readiness probe.
readinessProbe: {}

#
# Slurm compute (slurmd) configurations.
Expand Down
Loading