Unify DSV4 onto the canonical MoE fold and requalify to K3 = 0 - #48
Closed
kiddyboots216 wants to merge 0 commit into
Closed
Unify DSV4 onto the canonical MoE fold and requalify to K3 = 0#48kiddyboots216 wants to merge 0 commit into
kiddyboots216 wants to merge 0 commit into
Conversation
This was referenced Aug 11, 2026
Closed
Broly Security ScanNote Summary 0 actionable finding(s) in this PR 3 finding(s) below the No finding is at or above Note Re-scan this PR anytime with
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+79
to
+83
| trainer = torch.load( | ||
| RD / f"campaign2/dumps_dec39_trainer/components.rank{args.rank}.pt", | ||
| map_location="cpu", | ||
| weights_only=False, | ||
| ) |
|
|
||
|
|
||
| def load_pass(path: Path) -> dict: | ||
| d = torch.load(path, map_location="cpu", weights_only=False) |
Comment on lines
+48
to
+52
| trainer = torch.load( | ||
| RD / "campaign2/dumps_dec39_trainer2/components.rank0.pt", | ||
| map_location="cpu", | ||
| weights_only=False, | ||
| ) |
| else: | ||
| pass_file = args.pass_file | ||
|
|
||
| sampler = torch.load(pass_file, map_location="cpu", weights_only=False) |
| parser.add_argument("--vocab-size", type=int, default=129280) | ||
| args = parser.parse_args() | ||
|
|
||
| capture = torch.load(args.capture, map_location="cpu", weights_only=False) |
Comment on lines
+25
to
+32
| trace = json.load(open(args.trace)) | ||
| doctored = copy.deepcopy(trace) | ||
| for cap in doctored["captures"]: | ||
| cap["output_ids"][args.decision] = args.token | ||
| prompt_len = len(cap["prompt_ids"]) | ||
| cap["full_ids"][prompt_len + args.decision] = args.token | ||
| doctored["label"] = f"{trace['label']}-doctored-d{args.decision}-t{args.token}" | ||
| json.dump(doctored, open(args.output, "w"), indent=1) |
Comment on lines
+25
to
+29
| trainer = torch.load( | ||
| RD / "campaign2/dumps_dec39_trainer2/components.rank0.pt", | ||
| map_location="cpu", | ||
| weights_only=False, | ||
| ) |
|
|
||
|
|
||
| def _post(url: str, payload: dict[str, Any]) -> dict[str, Any]: | ||
| response = requests.post(f"{url.rstrip('/')}/generate", json=payload, timeout=900) |
Comment on lines
+75
to
+77
| tokenizer = AutoTokenizer.from_pretrained( | ||
| str(model_path), trust_remote_code=True, local_files_only=True | ||
| ) |
Comment on lines
+61
to
+65
| response = requests.post( | ||
| f"{url.rstrip('/')}/api/v1/retrieve_future", | ||
| json={"request_id": request_id}, | ||
| timeout=300, | ||
| ) |
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trainer half of the DSV4 canonical-fold unification (serving half: togethercomputer/xorl-sglang#18). Built on #45 plus a merge of #44, this migrates DSV4 off the architecture-scoped NCCL-tree contributor-order reproduction onto the shared
canonical_moe_fold_v1— the deliberate byte change #45 flagged as requiring full requalification, which this branch carries end to end (K3 exactly 0.0 at the 64-decision trained-adapter promotion replay, k3_max 0.0, decode 5.5 tok/s).Fold switch (
1adc5db7)exchange_variable_and_nccl_tree_chain_sum([1..7,0] left-associative chain) is retired;exchange_variable_and_canonical_foldkeeps DSV4's variable-row all-to-all transport and reduces the rank-ordered arrivals withcanonical_moe_fold_v1— the same byte program serving evaluates through its gated canonical post-experts combine.Launch-geometry mirroring (
facace92)Exact-head scoring kernel (
41bd2c54)log_softmaxwith the batch-invariant Triton kernel, whose BF16 rounding differs from ATen's on boundary rows (proven at one decision: the f64 truth sits 5.5e-8 past the bf16 boundary; the entire trunk through final-norm was byte-equal). The DSV4 exact head's forward VALUE now uses the serving kernel; the surrogate VJP keeps FP32 reference math.Qualification record (
e940116f, plan doc + lane log)dsv4_expert_banksadapter; 64-decision promotion at K3 = 0.0.Merge conflicts with #44 resolved per the reconciliation notes (auto.py keeps both the Qwen capability resolution and the DSV4 fail-closed registration; single-writer + 948-factor export both preserved). Supersedes the combine-order half of #45; intended for the #41 -> #43 -> #44 -> #45 restack by the reconciliation owner.