Skip to content

Admit Ulysses head-sharding into the exact byte contract (attention side) - #53

Closed
kiddyboots216 wants to merge 1 commit into
pr/pp-byte-alignmentfrom
pr/ulysses8-exact
Closed

Admit Ulysses head-sharding into the exact byte contract (attention side)#53
kiddyboots216 wants to merge 1 commit into
pr/pp-byte-alignmentfrom
pr/ulysses8-exact

Conversation

@kiddyboots216

@kiddyboots216 kiddyboots216 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Admit Ulysses head sharding into the exact byte contract

Stacked on #52. This PR contains production code and conventional tests only.

What changes

  • Make the context-parallel strategy explicit at call sites, so the ordering of RoPE and head exchange cannot silently change.
  • Fail closed on uneven Q/KV head partitions and on exact-lane kernel fallback.
  • Establish the attention-side byte contract for Ulysses degrees 2, 4, and 8 while keeping unsupported hybrid/GDN compositions closed.

Gates

  • FA4 head-bucket invariance at the production head geometry: 5 passed.
  • End-to-end Ulysses-1 versus Ulysses-N byte fixtures at degrees 2, 4, and 8, including padding and GQA replication branches: all verdicts passed.
  • CPU admission and pipeline regressions: 45 passed.

Scope

This PR does not broaden the admitted production topology by itself. Hybrid models remain fail-closed until the GDN context-parallel program is present and jointly admitted. The byte claims are toolchain-scoped and were verified on H100 with the pinned Torch, CUDA, FA4, CUTLASS DSL, and Quack versions recorded by the test environment.

@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

Validate head divisibility before collectives, make sync-versus-async selection explicit, and reject unsupported GDN fallback. Add CPU admission, distributed byte-alignment, and FA4 head-bucket invariance tests.
@kiddyboots216

Copy link
Copy Markdown
Contributor Author

Superseded by #57, which consolidates the complete exact trainer-serving stack directly onto main.

@kiddyboots216
kiddyboots216 deleted the pr/ulysses8-exact branch August 17, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant