Skip to content

Fix Mooncake replay cleanup with extended leases - #58

Open
kiddyboots216 wants to merge 3 commits into
mainfrom
fix/r55-mooncake-lease-cleanup-20260816
Open

Fix Mooncake replay cleanup with extended leases#58
kiddyboots216 wants to merge 3 commits into
mainfrom
fix/r55-mooncake-lease-cleanup-20260816

Conversation

@kiddyboots216

Copy link
Copy Markdown
Contributor

Summary

  • force-delete R3 replay payloads only after the distributed all-rank completion rendezvous
  • preserve normal lease-aware deletion on failed or cancelled backend calls
  • check Mooncake status codes, retry transient failures, and surface retained-key metrics
  • roll back every unpublished partial-put chunk and block further publishing after incomplete cleanup

Validation

  • 67 focused server tests passed
  • Ruff, formatting, pre-commit, and diff checks passed
  • real Mooncake v0.3.9 integration with a 300-second lease: normal delete returned -706 and retained the key; post-consumption forced cleanup removed it with zero failed or pending keys
  • independent read-only review found no remaining blockers

The separate replay-payload packaging slowdown is intentionally not addressed here.

@kiddyboots216
kiddyboots216 requested a review from qywu August 16, 2026 09:57
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant