Repository navigation
Conversation
Restore the go directive to 1.24.0, the floor required by golang.org/x/tools v0.39.0. Raising it to 1.27.1 would force downstream consumers such as golangci-lint (go 1.26.0) onto a newer toolchain without any code needing it. Align the README minimum with go.mod.
tomarrell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
actions/checkoutandactions/setup-goto v7, and read the Go version fromgo.modso CI tests against the module's declared minimum. Checkout now runs before setup-go sogo.modis available.Correct the README's minimum Go version to 1.24.0 to match
go.mod. That floor is set bygolang.org/x/toolsv0.39.0. The go directive stays at 1.24.0 so downstream consumers such as golangci-lint (currentlygo 1.26.0) aren't forced onto a newer toolchain.Validated:
go test ./...andgo vet ./...pass on Go 1.24.0, 1.26.0 and 1.27.1;go mod tidy -diffis clean.