Removing instrument base#133
Merged
marcosfrenkel merged 2 commits intotoolsforexperiments:masterfrom May 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QCoDeSDeprecationWarningraised on import ofqcodes.instrument.base. The class still exists; only the module path was deprecated, so this swaps the 4 import sites tofrom qcodes.instrument import InstrumentBase.qcodes<0.55pin inpyproject.toml(added in pinned qcodes to working version #132 as a workaround for this same warning) — no longer needed.AGENTS.md,docs/agents/*) that were committed earlier on this branch.Note on the branch name:
removing_instrument_basewas aspirational. The deprecation turned out to be a module-path move, not a class removal, so the actual fix is minimal —InstrumentBaseremains the parent ofParameterManagerandProxyInstrumentModule.