Skip to content

Remove hardcoded styling and unused colors from DiffRenderer #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paololeonardi wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −37
Open

Remove hardcoded styling and unused colors from DiffRenderer #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions Sources/gitdiff/Core/PlatformColors.swift
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Sources/gitdiff/Views/DiffFileView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,5 +110,4 @@ struct DiffFileView: View {

DiffFileView(file: sampleFile)
.padding()
.background(Color.appBackground)
}
1 change: 0 additions & 1 deletion Sources/gitdiff/Views/DiffLineView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,5 +142,4 @@ struct DiffLineView: View {
)
)
}
.background(Color.appBackground)
}
4 changes: 0 additions & 4 deletions Sources/gitdiff/Views/DiffRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ public struct DiffRenderer: View {
.font(.caption)
.foregroundColor(.secondary)
}
.padding()
.frame(maxWidth: .infinity, maxHeight: .infinity)
} else if let files = parsedFiles, files.isEmpty {
VStack(spacing: 20) {
Expand All @@ -58,18 +57,15 @@ public struct DiffRenderer: View {
.multilineTextAlignment(.center)
.padding(.horizontal)
}
.padding()
.frame(maxWidth: .infinity, maxHeight: .infinity)
} else if let files = parsedFiles {
VStack(spacing: 16) {
ForEach(files) { file in
DiffFileView(file: file)
}
}
.padding()
}
}
.background(Color.appBackground)
.task(id: diffText) {
self.parsedFiles = try? await DiffParser.parse(diffText)
}
Expand Down