Repository navigation
docs(contributing): require both conditions for compat behavior fixes - #2125
Merged
Merged
Conversation
Compat fixes for behavior that differs from Lodash must now both compile against @types/lodash in strict mode and be backed by a call in real public code, instead of satisfying only one of the two. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Fixing behavior that differs from Lodash" section in
CONTRIBUTING.mdaccepted a compat difference when at least one of the two conditions held: the call compiles against@types/lodashin strict mode, or real public code makes the call.This PR changes it so that both conditions must hold. A pull request that satisfies only one of them will be closed even when the fix is correct.
Changes
🤖 Generated with Claude Code