Repository navigation
feat(usePageVisibilityEffect): add usePageVisibilityEffect and deprecate useVisibilityEvent - #546
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c9e27b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +527 B (+0.46%) Total Size: 116 kB 📦 View Changed
ℹ️ View Unchanged
|
hyesungoh
added this pull request to stack #547
September 30, 2026 02:35
hyesungoh
marked this pull request as ready for review
September 30, 2026 07:50
Member
|
Thanks, this looks good! One thing on the changeset: #435 announced that |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1-base #546 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 70 71 +1
Lines 2282 2287 +5
Branches 735 735
=========================================
+ Hits 2282 2287 +5 🚀 New features to boost your workflow:
|
hyesungoh
force-pushed
the
feat/use-page-visibility-effect
branch
from
October 7, 2026 08:52
30078f7 to
18625de
Compare
Member
Author
…ate useVisibilityEvent useVisibilityEvent runs a callback when the value of usePageVisibility would change, but the names do not show that the two are a pair, and it is the only hook with an *Event suffix. Add usePageVisibilityEffect with the same signature and behavior, keep useVisibilityEvent as a deprecated alias of it, and switch useImpressionRef to the new name.
… deprecated alias useVisibilityEvent moves into the usePageVisibilityEffect folder as a one-line alias, its pages are removed, the usePageVisibilityEffect page says it was renamed, and the old URL redirects to the new page.
hyesungoh
force-pushed
the
feat/use-page-visibility-effect
branch
from
October 7, 2026 09:09
18625de to
c9e27b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #541
usePageVisibilityEffect. It has the same signature and behavior asuseVisibilityEvent, and its name pairs withusePageVisibilitythe wayuseOutsideClickEffectnames an effect hook.useVisibilityEventis now a deprecated alias ofusePageVisibilityEffect. It is the same function, so existing calls keep working, and editors show it as deprecated.useImpressionRefand theusePageVisibilitydocs now point to the new name, and so does the Common needs table in the agent skill.Stacked on #545, which adds the tooling for deprecated exports. This PR targets that branch, so its diff shows only the changes for #541. Once #545 is merged, it is rebased onto
v1-base.Tests
The tests moved to
usePageVisibilityEffect.test.tsunchanged. One added test checks thatuseVisibilityEventis the same function, which also keeps the alias file covered.Checklist
yarn run fixto format and lint the code and docs? (yarn testpasses)yarn run test:coverageto make sure there is no uncovered line?